Disable Mooncake on prerelease; bump min Julia to 1.10.2; regroup CI tests #2569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turing.jl documentation for PR #2569 is available at: |
penelopeysm
force-pushed
the
py/no-mooncake-pre
branch
from
9339cbb to
22569ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
=======================================
Coverage 85.86% 85.86%
=======================================
Files 21 21
Lines 1429 1429
=======================================
Hits 1227 1227
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 15346521153Details
💛 - Coveralls |
penelopeysm
changed the title
mhauru
approved these changes
May 30, 2025
This was referenced May 30, 2025
|
Regarding test grouping, stdlib/distributions has dropped to only 5 minutes, so I lumped it into "everything else". The rest is the same. Between #2564 and this PR, we've gone from 6 test groups and 2.5 hours to 4 test groups and 45 minutes 😄 |
penelopeysm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2570
Mooncake doesn't precompile on 1.12, so this is a very similar fix to TuringLang/DynamicPPL.jl#921. I was getting tired of CI not passing, and also the whole env not precompiling meant that potential real issues would be masked.
In the process, we discovered that
sample()was taking a very long time to compile on v1.10.0. This PR therefore also bumps the minimum version to 1.10.2, which is the first patch where this performance bug is fixed. See #2570 for more discussion (and #2571 where I was bisecting Julia patch versions).I also edited CI to balance out the test times. The new groups are:
mcmc/gibbs: ~ 45 minutesmcmc/Inference: ~10 minutesad: ~30 minuteseverything else: ~ 30 minutes